Don't use Dispatcher for suspendReadableAndRead and TLS initialization on Node.js
#3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
changed the title
Dispatcher for suspendReadableAndRead and TLS init on Node.jsDispatcher for suspendReadableAndRead and TLS initialization on Node.js
|
@mikeshepherd @gvolpe Ok, here's another attempt 😅 I published |
Thanks @armanbilge, we'll give this a try and get back to you. But it looks good to me reading it 👍 |
armanbilge
commented
Nov 29, 2023
| private[this] var readableCounter = 0 | ||
| private[this] var readable = false |
There was a problem hiding this comment.
I could have sworn this didn't work initially 🤔 but seems fine now.
This was referenced Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors reported in #3336 and #3338.
By introducing some custom concurrent data structures, we can completely avoid
Dispatcher, the indirection and performance cost, and thedispatcher already shutdownerrors that have been plaguing us.