Add Scalafmt #210
Merged
Add Scalafmt #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsrh
reviewed
Jan 7, 2020
| @@ -17,7 +17,7 @@ matrix: | |||
| - jdk: openjdk11 | |||
|
|
|||
| script: | |||
| - sbt "+ test" | |||
| - sbt ";scalafmtSbtCheck; +scalafmtCheckAll; +test" | |||
There was a problem hiding this comment.
Is the + really necessary here?
There was a problem hiding this comment.
You mean on the scalafmtCheckAll? It's not strictly necessary since there's no version-specific code at the moment, but if we do add it (for Dotty or whatever), it would be really easy to forget to change this.
larsrh
approved these changes
Jan 7, 2020
|
@non Do you have any objection to Scalafmt here? |
rossabaker
reviewed
Jan 7, 2020
|
@rossabaker Done. I do prefer the aligned version at this point, personally, but I guess we can change it in the future. |
larsrh
approved these changes
Jan 7, 2020
rossabaker
approved these changes
Jan 7, 2020
|
Should be good now, and yes, agree on squashing! |
travisbrown
force-pushed
the
topic/scalafmt
branch
from
9049bff
to
8be5afc
Compare
|
I went ahead and rebased manually since it was getting kind of messy. Will merge when green. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to go ahead and do this. I've copied the configuration from Cats.