Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using scribe backend #1

Closed
DavidGregory084 opened this issue Apr 25, 2018 · 2 comments
Closed

Consider using scribe backend #1

DavidGregory084 opened this issue Apr 25, 2018 · 2 comments

Comments

@DavidGregory084
Copy link
Member

Hey @ChristopherDavenport, this is a really nice project! Looks great!

I was wondering whether you'd consider a PR to use outr/scribe rather than log4s or making the logging backend configurable? scribe has support for scala-native / scala.js and great performance, and it can still be used as an slf4j backend.
@ChristopherDavenport
Copy link
Member

I would definitely consider it. After thinking about constraints I'm wondering whether we could abstract the fundamental algebra or something similar and then have backends which implement in different modules so it operates to each teams individual taste.

How do you feel about the structure of the algebra, as it seems fairly consistent across the logging libraries?

@DavidGregory084
Copy link
Member Author

Yeah, it looks good to me - certainly covers everything that I'd use personally 👍

Merged
rossabaker pushed a commit that referenced this issue Jan 12, 2022
@dj707chen
Merge pull request #1 from weipingc/main
3e95c6d 
Update PagingSelfAwareStructuredLogger.scala to use String.slice instead of substring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidGregory084 @ChristopherDavenport