Add an opentelemetry module
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can also port this over to the 0.1 branch pretty easily, we just needed it for 0.0 |
|
I was just looking for this today! |
Update fs2-io to 3.2.3
…ava-1.3.2 Update libhoney-java to 1.3.2
Iterating on X-Ray support
…-1.1.0' into topic/update-bundle
…topic/update-bundle
…nto topic/update-bundle
…nto topic/update-bundle
…topic/update-bundle
…to topic/update-bundle
…to topic/update-bundle
…2.6.0' into topic/update-bundle
…topic/update-bundle
…-static-2.0.46.Final' into topic/update-bundle # Conflicts: # build.sbt
…pic/update-bundle
…topic/update-bundle # Conflicts: # build.sbt
…update-bundle # Conflicts: # build.sbt
…to topic/update-bundle
Fix example in documentation
add long to the allowed values
Update Kernel.scala - cleanup documentation
Make ddspan public
Setting appropriate error flags and logs in JaegerSpan
Add utilities for converting Kleisli[F, Span[F], A] to F[A]
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
…atchez into bring-odin-module-back
Bring back Odin module
Add OpenTelemetry module
|
I merged #539. Please take a look and see if there's anything from this PR we should incorporate. |
mpilquist
added a commit
that referenced
this pull request
Nov 16, 2022
Add OpenTelemetry support from #368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
natchez-opentelemetrymodule which allows span reporting via theopentelemetry-javaproject.The
Utilsobject contains a helper to turn theOpenTelemetryCompletableResultCodeclass into anF[Unit]givenAsync[F], this is useful for implementingResources for clean shutdown logic.Shutdownableis a little abstraction to unify all the interfaces that have ashutdown(): CompletableResultCodemethod inOpenTelemetry, since they have no common interface.OpenTelemetrySpanandOpenTelemetryEntryPointare heavily based on thenatchez-jaegerversions, with tweaks to make them work withOpenTelemetry.The
OpenTelemetryobject which end users should interact with has these methods:liftcan be used to lift anyF[T]whereTis anOpenTelemetryclass with ashutdownmethod into aResource[F, T], it asks for a name to provide a nice error messageentryPointis the main way to make anEntryPointand has a boolean flag to allow the user to globally register theOpenTelemetryif that's helpful, this defaults to false.globalEntryPointwill use the globally registeredOpenTelemetryto create anEntryPointNote that this is currently using
OpenTelemetrylibraries at1.4.0-SNAPSHOTbecause I found a bug while developing this this broke the shutdown logic.The issue is here open-telemetry/opentelemetry-java#3306 and it was closed by this PR open-telemetry/opentelemetry-java#3307 so it should make it into the next release.