Removed custom SCRAM implementation in favor of library provided by... #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngres and used in official JDBC driver
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 84.77% 84.52% -0.26%
==========================================
Files 111 110 -1
Lines 1327 1286 -41
Branches 27 25 -2
==========================================
- Hits 1125 1087 -38
+ Misses 202 199 -3
Continue to review full report at Codecov.
|
|
Any chance for a release with this PR soon? |
|
tagged v0.0.21, building now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Ongres and used in official JDBC driver. No need to maintain the SCRAM crypto stuff this way and guaranteed we won't have any weird compatibility issues.
BTW, the use of
SecureRandom.getInstanceStrong()in the original implementation led to some hanging issues on machines without enough entropy. See https://tersesystems.com/blog/2015/12/17/the-right-way-to-use-securerandom/ for details on this, but this led me to investigate what the official JDBC client does for nonce creation. That then led me to this SCRAM library from Ongres which is nicely decoupled from everything JDBC.