findByIds with empty array returns value

[icepeng]

If the given id array is empty, we expect an empty array to be returned, but actually all rows of that entity are returned.

I checked that the where clause is missing from the generated query when the Id array is empty. Is this behavior intended?

[NoNameProvided]

The issue is that in /src/query-builder/SelectQueryBuilder.ts#L717-L730 it passes the array without checking to the QueryBuilder.createWhereIdsExpression function what as can be seen below, simply generates and where expression for every id in the array. If there are no ids, then no expression will be added.

typeorm/src/query-builder/QueryBuilder.ts

Lines 584 to 598 in fe24877

	const whereStrings = ids.map((id, index) => {
	id = id instanceof Object ? id : metadata.createEntityIdMap(id);
	const whereSubStrings: string[] = [];
	metadata.primaryColumns.forEach((primaryColumn, secondIndex) => {
	whereSubStrings.push(alias + this.escape(primaryColumn.databaseName) + "=:id_" + index + "_" + secondIndex);
	parameters["id_" + index + "_" + secondIndex] = primaryColumn.getEntityValue(id);
	});
	metadata.parentIdColumns.forEach((parentIdColumn, secondIndex) => {
	whereSubStrings.push(alias + this.escape(parentIdColumn.databaseName) + "=:parentId_" + index + "_" + secondIndex);
	parameters["parentId_" + index + "_" + secondIndex] = parentIdColumn.getEntityValue(id);
	});
	return whereSubStrings.join(" AND ");
	});
	const whereString = whereStrings.length > 1 ? "(" + whereStrings.join(" OR ") + ")" : whereStrings[0];

However, I am not sure how this should be handled as for the fixing also both andWhereInIds and orWhereInIds needed to be taken into account.

[icepeng]

I also found that whereString was a problem, but not sure about how to handle when whereStrings.length === 0

[pleerock]

Sounds like an issue. Feel free to contribute

[pleerock]

fixed and will be released in 0.1.5