Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column option "select" type error. #1110

Closed
jcudzich opened this issue Oct 28, 2017 · 1 comment
Closed

Column option "select" type error. #1110

jcudzich opened this issue Oct 28, 2017 · 1 comment
Labels

Comments

@jcudzich
Copy link

Column option "select" not working (exactly cannot compile typescript) when I use syntax:

@Column('int', {
  select: false
})
property: number;

But works correctly in syntax:

@Column({
  type: 'int',
  select: false
})
property: number;
@pleerock pleerock added the bug label Nov 1, 2017
@pleerock
Copy link
Member

This is fixed and fix will be released in next version

pleerock pushed a commit that referenced this issue Nov 22, 2017
* master:
  fixes #996
  fixed failing test
  added test for #1145
  added "ON CONFLICT" cause support for #1090
  removed only test
  added support for indices and listeners in embeddeds
  version bump
  added test for #1178
  added test for #1210
  fixes #1201
  removed only test
  fixes #1118
  fixed comments style
  version bump
  fixes #1119 and #1205
  fixes #1110

# Conflicts:
#	package.json
#	src/entity-manager/EntityManager.ts
#	src/migration/MigrationExecutor.ts
#	src/query-builder/InsertQueryBuilder.ts
#	src/repository/BaseEntity.ts
#	src/subscriber/Broadcaster.ts
#	test/github-issues/1178/entity/Post.ts
#	test/github-issues/1178/issue-1178.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants