Cannot execute increment on column defined by embedded entity

[smonv]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[x] postgres
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[ ] latest
[ ] @next
[x] 0.2.8 (or put your version here)

I have a embedded entity contain some friend statistics of a User. When user send a friend request to other user, I want increase friend.sent counter but the query always try to update null to frientSent.

My entity:

class FriendStats {
    @Column('bigint', { default: 0 })
    count: number;

    @Column('bigint', { default: 0 })
    sent: number;

    @Column('bigint', { default: 0 })
    received: number;
}

@Entity('users')
export class User {
    @Column(type => FriendStats)
    friend: FriendStats;
}

Query:

await this.manager.increment(User, { id: user.id }, 'friend.sent', 1);

TypeORM generated SQL:

UPDATE "users" SET "friendSent" = $2, "updatedAt" = CURRENT_TIMESTAMP WHERE "id" = $1 -- PARAMETERS: ["123456",null]

Error

query failed: UPDATE "users" SET "friendSent" = $2, "updatedAt" = CURRENT_TIMESTAMP WHERE "id" = $1 -- PARAMETERS: ["123456",null]

error: { error: null value in column "friendSent" violates not-null constraint ......

[apellizzn]

This seems a bit strange, considering that the following is the output of the increment function in the EntityManager.ts

await this.
createQueryBuilder(entityClass, "entity")
.update(entityClass)
.set({
  [propertyPath]: () => this.connection.driver.escape(column.databaseName) + " + " + Number(value)
})
.where(conditions)
.execute();

There should be at least a + in your query output!

[smonv]

I'm tried with createQueryBuilder and update but got same error and same generated query.

await manager.createQueryBuilder(User, 'u')
                .update()
                .set({
                    'friend.sent': () => `"friendSent" + ${Number(1)}`,
                })
                .where({ id: user.id }).execute();

Query:

UPDATE "users" SET "friendSent" = $2, "updatedAt" = CURRENT_TIMESTAMP WHERE "id" = $1 -- PARAMETERS: ["123456",null]

Error

error: { error: null value in column "friendSent" violates not-null constraint

[pleerock]

We need a PR with a failing test for this issue.

[smonv]

Thanks for the fix.

…

On Sat, Feb 9, 2019 at 13:11 Umed Khudoiberdiev ***@***.***> wrote: Closed #3182 <#3182> via #3578 <#3578>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3182 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIjDnV7WTgx09xnWpOEc-qV9cMoHFO8Kks5vLmaQgaJpZM4Y7QO_> .