fix(3182): fixed increment/decrement values of embeded entity #3578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root of problem:
Current implementation of increment/decrement method for embedded property define values to update like this:
But update query builder do not support define key as string with "dot notation path".
Solution:
Convert:
to:
Note: Sure we can add support of "dot notation path" into
set()
method but right nowset()
method accept strongly typed argument and I think it is better keep this functionality and just update increment/decrement function as it is presented in this PR.Fixes #3182