Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'orphanedRowAction' option to EntitySchema #7417

Closed
1 of 4 tasks
oscar-v0 opened this issue Feb 24, 2021 · 1 comment · Fixed by #7625
Closed
1 of 4 tasks

Add 'orphanedRowAction' option to EntitySchema #7417

oscar-v0 opened this issue Feb 24, 2021 · 1 comment · Fixed by #7625
Labels
new feature requires triage

Comments

@oscar-v0
Copy link

oscar-v0 commented Feb 24, 2021 •
edited
Loading

Feature Description

The 'orphanedRowAction' property was recently added to RelationOptions thanks to @nebkat (#7105). However, this option is still missing for EntitySchemaRelationOptions. Can this be added?

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.

I've never contributed to open source but it seems like a simple addition.
@JamieWritesCode
Copy link
Contributor

JamieWritesCode commented May 6, 2021 •
edited
Loading

Seems like a simple oversight when the original change was made. I'll try and take a look at this soon if no one more qualified is interested in taking the lead. Unfortunately, it seems as though those of us using separated entity definitions aren't getting a lot of love at the moment.

JamieWritesCode pushed a commit to JamieWritesCode/typeorm that referenced this issue May 6, 2021
feat: add schema support for orphanedRowAction
8bc51f2 
Adds support for setting the action for orphaned relation rows when using separate entity definitions

Fixes typeorm#7417
@JamieWritesCode JamieWritesCode mentioned this issue May 6, 2021
Merged
7 tasks
AlexMesser pushed a commit that referenced this issue May 8, 2021
@JamieWritesCode
feat: add orphanedRowAction option to EntitySchemaRelationOptions (#…
a8eb49a 
…7625)

Adds support for setting the action for orphaned relation rows when using separate entity definitions

Fixes #7417

Co-authored-by: Jamieson Baker <jamieson@sophus.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature requires triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add schema support for orphanedRowAction JamieWritesCode/typeorm
2 participants
@JamieWritesCode @oscar-v0