Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mongo replica set #7908

Merged
merged 3 commits into from
Jul 18, 2021
Merged

fix: mongo replica set #7908

merged 3 commits into from
Jul 18, 2021

Conversation

klassm
Copy link
Contributor

@klassm klassm commented Jul 15, 2021

From typeorm > 0.2.28 parsing the connection string broke our database setup. In our setup we use a replicaSetup - however the required parameters tls and replicaSet were never added to the connection string.

This PR will add the two parameters, in addition to a new test that parses the connection string (as I was looking for how the parsing works).

There is no new test for the actual adding of the two query parameters. If you can point me towards an example test case, I can also provide one for this case.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

So all testcase use a uniform expectation library
@klassm klassm changed the title Fix/7130/mongo replica set fix: mongo replica set Jul 15, 2021
@imnotjames imnotjames merged commit 9212df4 into typeorm:master Jul 18, 2021
imnotjames pushed a commit to imnotjames/typeorm that referenced this pull request Jul 21, 2021
* test: migrates should syntax to expect

So all testcase use a uniform expectation library

* fix: adds replicaSet and tls option to mongo connection url

fixes 7130

* test: add a unit test for the connection string building
imnotjames pushed a commit to imnotjames/typeorm that referenced this pull request Jul 21, 2021
* test: migrates should syntax to expect

So all testcase use a uniform expectation library

* fix: adds replicaSet and tls option to mongo connection url

fixes 7130

* test: add a unit test for the connection string building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants