Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: consistent parsing and escaping of table names in QueryRunners #7950

Merged
merged 2 commits into from
Jul 24, 2021
Merged

feat: consistent parsing and escaping of table names in QueryRunners #7950

merged 2 commits into from
Jul 24, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 24, 2021 •
edited
Loading

Description of change

this refactors escapePath and parseTableName so that when we parse
and serialize the table names they should work the same between the two

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames
fix: use only table name in constraint naming strategy
e0b80a8 
this enforces a consistent name even if there's a name that's
fully qualified or just a table name.  this solves a few
issues that crop up if you're using custom schemas or
databases in one connection but connect to that same
schema or database as the primary connection options
in another
@imnotjames
feat: consistent parsing and escaping of table names in QueryRunners
587e905 
this refactors `escapePath` and `parseTableName` so that when we parse
and serialize the table names they should work the same between the two
@imnotjames imnotjames force-pushed the refactor/7867/escape-path-and-parse-table-name branch from 1deee1c to 587e905 Compare July 24, 2021 04:07
@imnotjames imnotjames merged commit bd9e767 into typeorm:master Jul 24, 2021
@imnotjames imnotjames deleted the refactor/7867/escape-path-and-parse-table-name branch July 24, 2021 04:48
@dotMortis dotMortis mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@imnotjames