Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/integrating a smaller scale/double strand? #113

Closed
wants to merge 1 commit into from
Closed

Adding/integrating a smaller scale/double strand? #113

wants to merge 1 commit into from

Conversation

ldexterldesign
Copy link

https://twitter.com/ldexterldesign/status/347352040642576384

Hey,

I need smaller numbers for my scale, so would doing this [above] - correct me if I'm wrong - be the place to extend the scale downwards? I guess the same principle would apply if you were doing double strand stuff (i.e. multiple scales)?

If so, I would have to update this piece of code in _typeplate.scss:
// Multi-dimensional array, where:
// the first value is the name of the class
// and the second value is the variable for the size
$sizes: tera $tera, giga $giga, mega $mega, alpha $alpha, beta $beta, gamma $gamma, delta $delta, epsilon $epsilon, zeta $zeta;

... which would dictate this should be located in _vars-typeplate.scss too? Remember, I don't want to have to edit _typeplate.scss itself! :P

Best regards,

Hey,

I need smaller numbers for my scale, so would doing this [above] - correct me if I'm wrong - be the place to extend the scale downwards? I guess the same principle would apply if you were doing double strand stuff (i.e. multiple scales)?

If so, I would have to update this piece of code in _typeplate.scss:
// Multi-dimensional array, where:
// the first value is the name of the class
// and the second value is the variable for the size
$sizes: tera $tera, giga $giga, mega $mega, alpha $alpha, beta $beta, gamma $gamma, delta $delta, epsilon $epsilon, zeta $zeta;

... which would dictate this should be located in _vars-typeplate.scss too? Remember, I don't want to have to edit _typeplate.scss itself! :P

Best regards,
@ldexterldesign
Copy link
Author

#112

@grayghostvisuals
Copy link
Contributor

The new vars file will help this where you can customize those default typescale variables by overriding Sass' !default flag.

@ldexterldesign
Copy link
Author

Hey,

Could you point me at the new variable file or doesn't it exist yet? (I thought I was using it already, but there's no $sizes var in my version?)

Kind thanks,

@grayghostvisuals
Copy link
Contributor

You should re-read my comment to you.
#109 (comment)

@ldexterldesign
Copy link
Author

I'll assume you mean the last part of that comment...

... and that you're recommending I make the change myself, because it doesn't already exist ( https://github.com/typeplate/typeplate.github.io/blob/development/typeplate/scss/_vars-typeplate.scss )?

Cheers,

@grayghostvisuals
Copy link
Contributor

Yeah the least part of my comment and yes that link you noted above. I would really hold off on any PRs atm until we can get out this next release. If you have a feature request or code suggestions file it as an issue first at this time so we can discuss it. Thanks again.

@ldexterldesign
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants