Play221 Update #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 15, 2014 13:39
…gular dependency as this is now fixed in angular.js webjar
|
I updated angular.js/require.js as the dependecy bug is now fixed. |
| @@ -8,12 +8,13 @@ define('angular', ['webjars!angular-locale_en-us.js'], function() { | |||
| return angular; | |||
| }); | |||
|
|
|||
| require(['angular', './controllers', './directives', './filters', './services'], | |||
|
|
|||
| require(['angular', './controllers', './directives', './filters', './services', 'webjars!angular-route.js'], | |||
There was a problem hiding this comment.
Hey @huntc, how does just angular work? I thought the webjars! prefix was needed.
There was a problem hiding this comment.
It is defined above:
I've found it good practice to do this in order to:
- not have webjars! throughout my code (and thus keep it portable); and
- have the module return something that makes sense rather than rely on globals throughout my code.
|
LGTM. @huntc? |
| @@ -0,0 +1,14 @@ | |||
| name := "angularjs_sample" | |||
There was a problem hiding this comment.
Can we please keep the name as "angular-seed-play"?
|
@nob13 Can you please squash your commits? |
|
I added a new pull request with squashed content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a workaround to add dependency to angular.routes.