forked from basarat/typescript-book
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript and other codes and fix several docs #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shuuji3 PRを送っていただき、大変ありがとうございます!お返事が遅くなって申し訳有りません。 |
@yohamta マージしていただき、ありがとうございます!:smile: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
こんにちは。TypeScriptの勉強をしていて、こちらの翻訳が大変参考になりました。どうもありがとうございます!😄
翻訳時点からオリジナルの本でもさまざまな箇所で更新が行われているのに気がついたので、日本語と最新版のdiffを取って、コード部分を中心に最新のものにアップデートしました。
すべては比較しきれなくて、実際にチェックした箇所は、翻訳元のTypeScript Deep Diveのセクションのうち、以下のセクションになります。
また、何箇所か目に付いたところについても、翻訳の修正や改善を行っています。
1つのPRでコミットが多くなってしまったので、もし確認しづらいようであれば、コミットを分割しようと思います。必要なら遠慮なく言ってください。よろしくお願いします🙏