Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code of Conduct to repository #554

Merged
merged 3 commits into from
Oct 9, 2022

Conversation

fsenaweb
Copy link
Contributor

@fsenaweb fsenaweb commented Oct 6, 2022

Thanks for contributing!

  • If you are making a significant PR, please make sure there is an open issue first
  • If you're just fixing typos or adding small notes, a brief explanation of why you'd like to add it would be nice :)

If you are contributing to README.md, DON'T. README.md is auto-generated. Please just make edits to the source inside of /docs/basic. Sorry, we get that it is a slight pain.

@filiptammergard
Copy link
Collaborator

Thanks @fsenaweb, I think this is great and the code of conduct looks good to me. Leaving to @sw-yx to make the call on the content of the code of conduct.

Make sure to run Prettier though, to get proper formatting!

@fsenaweb
Copy link
Contributor Author

fsenaweb commented Oct 7, 2022

Thanks @filiptammergard. I produced the code of conduct and I didn't get to apply the prettier. However, I made a small change in PR to improve and adapt to the prettier. Thank you for the opportunity to contribute.

@fsenaweb
Copy link
Contributor Author

fsenaweb commented Oct 7, 2022

@filiptammergard and @sw-yx. I apologize for a formatting error. I did the installation through yarn, however, I believe that the yarn format command was not performed correctly, that's why I was showing the error in the actions process. I believe it is now working in its entirety.

I count on everyone's understanding and I hope that my contribution can help, as I am a great admirer of your work.

@filiptammergard
Copy link
Collaborator

No problem @fsenaweb! Now everything looks great from my side. Let's hear what @sw-yx says!

@eps1lon eps1lon linked an issue Oct 8, 2022 that may be closed by this pull request
@eps1lon eps1lon requested a review from swyxio October 8, 2022 08:31
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. But should be signed off by everybody mentioned in this document

Copy link
Collaborator

@swyxio swyxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay - LGTM!

@swyxio swyxio merged commit 847dba2 into typescript-cheatsheets:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code of Conduct Missing
4 participants