New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing mergers: no-caller, no-eval #135
Comments
This was actually changing my eslint config and the errors were non-blocking :) |
Oh hi again @joeyj-msft! I'm going to re-open this issue because it's still a bug I'd like to fix. π thanks for reporting! Let's assume 0.2.2 as the version. |
https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/Architecture.md#rule-mergers describes the root issue here. There are multiple instances of the |
@JoshuaKGoldberg I'm wondering if this could generically handle merging the configs: https://lodash.com/docs/4.17.15#merge |
Ah, I'd rather avoid using |
Makes sense. How about an interim approach at outputting the conflicting rules in the log? I'd be happy to take a look at that as the merge will get painful to implement for each case |
π Bug Report
tslint-to-eslint-config
version: dunno. used npx to runActual Behavior
my eslint config is not updated
console output
β¨ 101 rules replaced with their ESLint equivalents. β¨
π’ 4 ESLint rules behave differently from their TSLint counterparts: π’
π 2 errors thrown. π
Check ./tslint-to-eslint-config.log for details.
οΈπ 132 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. π
β All is well! β
log file
no-eval threw an error during conversion: Error: No merger for multiple output no-eval rule configurations.
at exports.convertRules (...\npm-cache_npx\14132\node_modules\tslint-to-eslint-config\src\rules\convertRules.js:37:67)
at exports.convertConfig (...\npm-cache_npx\14132\node_modules\tslint-to-eslint-config\src\conversion\convertConfig.js:15:48)
at
at process._tickCallback (internal/process/next_tick.js:189:7)
no-arg threw an error during conversion: Error: No merger for multiple output no-caller rule configurations.
at exports.convertRules (...\npm-cache_npx\14132\node_modules\tslint-to-eslint-config\src\rules\convertRules.js:37:67)
at exports.convertConfig (...\npm-cache_npx\14132\node_modules\tslint-to-eslint-config\src\conversion\convertConfig.js:15:48)
at
at process._tickCallback (internal/process/next_tick.js:189:7)
Expected Behavior
eslint config would be updated
Reproduction
Can you reply to this issue and let me know how much help you need to repro? I'd prefer not to just copy config/details from an internal repo.
The text was updated successfully, but these errors were encountered: