-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize tslint-react as an extended ruleset #656
Recognize tslint-react as an extended ruleset #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this PR @yasarsid! The changes so far look good.
However, when trying this out locally, I'm seeing this come up as an error in tslint-to-eslint-config.log
:
Could not resolve ESLint extension 'plugin:react/recommended'.: Error: Cannot find module 'C:\Code\tslinttest\plugin:react\recommended'
You'll need to add an entry to src/creation/summarization/retrieveExtendsValues.ts
that tells tslint-to-eslint-config
how to look up extended rules from the ESLint react ruleset.
@JoshuaKGoldberg Thanks for an awesome review and pointing out the problem ( along with the fix for it 👍 ) I made the changes and tested them locally - I am sharing a few findings Additional error message⛔ I did see an error in I wanted to be sure hence bring this up here - Error
Rulesets for react/recommendedThe Entries of recommended rules -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
So thorough, this is great! Yes, #666 is filed separately for the missing naming-convention merger. Much appreciated! |
PR Checklist
status: accepting prs
Overview
Recognize tslint-react as a extended ruleset.
Github Issue
If a rule extends from tslint-react , we will now add
react/recommended
to the configuration.Recommendation from
eslint-plugin-react
are present Here. I have left outeslint:recommended
not sure if that would be required.Have added unit tests and verified if the coverage remains at 100%.