Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): expose getParserServices from utils #1448

Merged
merged 3 commits into from Jan 14, 2020

Conversation

@armano2
Copy link
Member

armano2 commented Jan 13, 2020

This change got extracted from #716 as non breaking feature

@armano2 armano2 requested a review from bradzacher Jan 13, 2020
@typescript-eslint

This comment was marked as resolved.

Copy link

typescript-eslint bot commented Jan 13, 2020

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

bradzacher left a comment

LGTM - thanks for pulling this out

Note - there are build failures atm

@armano2

This comment has been minimized.

Copy link
Member Author

armano2 commented Jan 14, 2020

dev experimental-utils are not picked up in docker :(

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1448 into master will increase coverage by 1.55%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   94.02%   95.57%   +1.55%     
==========================================
  Files         143      143              
  Lines        6456     6458       +2     
  Branches     1822     1823       +1     
==========================================
+ Hits         6070     6172     +102     
+ Misses        210      110     -100     
  Partials      176      176
Impacted Files Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.4% <100%> (ø) ⬆️
...kages/eslint-plugin/src/rules/naming-convention.ts 87.88% <100%> (+0.03%) ⬆️
...xperimental-utils/src/eslint-utils/applyDefault.ts 100% <0%> (+16.66%) ⬆️
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 28.57% <0%> (+28.57%) ⬆️
...mental-utils/src/eslint-utils/getParserServices.ts 33.33% <0%> (+33.33%) ⬆️
...experimental-utils/src/eslint-utils/RuleCreator.ts 66.66% <0%> (+66.66%) ⬆️
...l-utils/src/eslint-utils/batchedSingleLineTests.ts 92.3% <0%> (+92.3%) ⬆️
packages/experimental-utils/src/ts-eslint/index.ts 100% <0%> (+100%) ⬆️
...perimental-utils/src/ts-eslint-scope/Definition.ts 100% <0%> (+100%) ⬆️
...xperimental-utils/src/ts-eslint-scope/Reference.ts 100% <0%> (+100%) ⬆️
... and 11 more
@bradzacher bradzacher merged commit 982c8bc into typescript-eslint:master Jan 14, 2020
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 95.57% (+1.55%) compared to 7b3e766
Details
typescript-eslint.typescript-eslint Build #20200114.18 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@armano2 armano2 deleted the armano2:getParserServices-part1 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.