-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental-utils): expose getParserServices from utils #1448
Merged
bradzacher
merged 3 commits into
typescript-eslint:master
from
armano2:getParserServices-part1
Jan 14, 2020
Merged
feat(experimental-utils): expose getParserServices from utils #1448
bradzacher
merged 3 commits into
typescript-eslint:master
from
armano2:getParserServices-part1
Jan 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
added
the
package: utils
Issues related to the @typescript-eslint/utils package
label
Jan 13, 2020
This comment has been minimized.
This comment has been minimized.
bradzacher
previously approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pulling this out
Note - there are build failures atm
dev experimental-utils are not picked up in docker :( |
Codecov Report
@@ Coverage Diff @@
## master #1448 +/- ##
==========================================
+ Coverage 94.02% 95.57% +1.55%
==========================================
Files 143 143
Lines 6456 6458 +2
Branches 1822 1823 +1
==========================================
+ Hits 6070 6172 +102
+ Misses 210 110 -100
Partials 176 176
|
bradzacher
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change got extracted from #716 as non breaking feature