Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-tslint): fix tslintConfig memoization key #1719


Copy link

Fixes #1692

Copy link

Thanks for the PR, @pelepelin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Mar 11, 2020
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #1719 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1719   +/-   ##
  Coverage   95.19%   95.19%           
  Files         148      148           
  Lines        6967     6968    +1     
  Branches     2007     2009    +2     
+ Hits         6632     6633    +1     
  Misses        124      124           
  Partials      211      211           
Flag Coverage Δ
#unittest 95.19% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
packages/eslint-plugin-tslint/src/rules/config.ts 100.00% <100.00%> (ø)

Copy link

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

On Windows eslint overrides with tslint rules do not match depending on existence of other files
3 participants