Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] handle computed member access #2288

Merged
merged 1 commit into from Jul 13, 2020
Merged

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Jul 11, 2020

fixes #2247

@typescript-eslint
Copy link
Contributor

@typescript-eslint typescript-eslint bot commented Jul 11, 2020

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug label Jul 11, 2020
Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks heaps for the fix!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-unnecessary-condition] handling computed member access fix(eslint-plugin): [no-unnecessary-condition] handle computed member access Jul 13, 2020
@bradzacher bradzacher merged commit 3a187ca into typescript-eslint:master Jul 13, 2020
8 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
2 participants