Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(typescript-estree): generate correct snapshots for jsx files #2992

Merged
merged 1 commit into from
Feb 2, 2021
Merged

test(typescript-estree): generate correct snapshots for jsx files #2992

merged 1 commit into from
Feb 2, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 2, 2021 •
edited

fix test regression introduced in #2290

I noticed this issue while i was investigating #2279

@armano2 armano2 added package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing labels Feb 2, 2021
@typescript-eslint

This comment has been minimized.

Sign in to view
@armano2 armano2 assigned armano2 and unassigned armano2 Feb 2, 2021
bradzacher
bradzacher approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!
Good catch.

@bradzacher bradzacher merged commit cfb749d into master Feb 2, 2021
@bradzacher bradzacher deleted the test/estree-jsx-snapshots branch February 2, 2021 08:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armano2 @bradzacher