Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Eliminate phantom dependency on "typescript" package #3623

Closed
wants to merge 1 commit into from
Closed

fix(types): Eliminate phantom dependency on "typescript" package #3623

wants to merge 1 commit into from

Conversation

octogonz
Copy link
Contributor

@octogonz octogonz commented Jul 10, 2021 •
edited

Fixes #3622

@bradzacher Let me know if you like this solution.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @octogonz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2021

Nx Cloud Report

CI ran the following commands for commit 657dbc5. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel

Sent with 💌 from NxCloud.

@octogonz octogonz mentioned this pull request Jul 10, 2021
Open
3 tasks
@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party bug Something isn't working labels Jul 31, 2021
@bradzacher bradzacher mentioned this pull request Jul 31, 2021
Merged
@bradzacher bradzacher added the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Mar 4, 2022
@bradzacher
Copy link
Member

Closing for housekeeping purposes.
Anyone is free to raise a fresh PR with these changes to continue this work!

@bradzacher bradzacher closed this Mar 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party bug Something isn't working stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@typescript-eslint/types has a phantom dependency on the "typescript" package
2 participants
@octogonz @bradzacher