Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align colors of code block #4324

Merged
merged 4 commits into from Dec 20, 2021
Merged

docs: align colors of code block #4324

merged 4 commits into from Dec 20, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 17, 2021

Overview

This PR aligns colors used in various code blocks on website, as for palette I used colors use theme in playground

this change fixes blinking of code blocks in dark mode.


dark mode code blocks do look different now:

old:

image
image

new:
image
image

@armano2 armano2 added the documentation Documentation ("docs") that needs adding/updating label Dec 17, 2021
@armano2 armano2 self-assigned this Dec 17, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 6b3993e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 44 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment has been minimized.

@netlify
Copy link

netlify bot commented Dec 17, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 6b3993e

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61bd5fb83daa41000923dda1

😎 Browse the preview: https://deploy-preview-4324--typescript-eslint.netlify.app

@armano2 armano2 marked this pull request as draft December 17, 2021 21:33
@armano2 armano2 marked this pull request as ready for review December 18, 2021 00:16
@armano2

This comment has been minimized.

@Josh-Cena
Copy link
Member

This site will surely make it into the favorites if you add this to the showcase some day😀 Looking forward to it!

@armano2 armano2 changed the title doc(parser): align colors of code block docs(parser): align colors of code block Dec 18, 2021
@bradzacher bradzacher changed the title docs(parser): align colors of code block docs: align colors of code block Dec 20, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working to make it look so much nicer!

@bradzacher bradzacher merged commit 17d91ce into main Dec 20, 2021
@bradzacher bradzacher deleted the doc/code-block-colors branch December 20, 2021 02:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants