Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-common): stable classname for code blocks #6125

Merged
merged 4 commits into from
Dec 18, 2021

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 18, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 18, 2021
@netlify
Copy link

netlify bot commented Dec 18, 2021

✔️ [V2]

🔨 Explore the source changes: d2aea02

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bd6a4459e210000899ca01

😎 Browse the preview: https://deploy-preview-6125--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6125--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator Author

@armano2 I hope that's what you had in mind? Also, about typescript-eslint/typescript-eslint#4284 (comment), after some inspection I believe you could use .theme-doc-sidebar-item-category-level-1 > div > a. I'd admit it's still not elegant, but less error-prone than using Infima class names. It's still up to you, and as long as it works, it's fine

@github-actions
Copy link

github-actions bot commented Dec 18, 2021

Size Change: +235 B (0%)

Total Size: 652 kB

Filename Size Change
website/build/assets/css/styles.********.css 101 kB +206 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 37.8 kB 0 B
website/build/assets/js/main.********.js 484 kB +29 B (0%)
website/build/index.html 29.3 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit 06bd44c into main Dec 18, 2021
@Josh-Cena Josh-Cena deleted the jc/codeblock-stable-classname branch December 18, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants