feat(utils): extract isNotTokenOfTypeWithConditions out of ast-utils' predicates

[MichaelDeBoey]

This is the negative version of what I did in #3977

[typescript-eslint]

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

❌ Deploy Preview for typescript-eslint failed.

🔨 Explore the source changes: 19be9df

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6216d0a143dfc200073fda69

[MichaelDeBoey]

Unfortunately, linting obliges me to add this type a second time 😢

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 19be9df. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 48 targets

• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 16.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/utils
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14.x - nx test @typescript-eslint/parser
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 14.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #4502 (4dc75d3) into main (823b945) will decrease coverage by 2.43%.
The diff coverage is 83.33%.

❗ Current head 4dc75d3 differs from pull request most recent head 19be9df. Consider uploading reports for the commit 19be9df to get more accurate results

@@            Coverage Diff             @@
##             main    #4502      +/-   ##
==========================================
- Coverage   94.62%   92.19%   -2.44%     
==========================================
  Files         149      204      +55     
  Lines        8072     8863     +791     
  Branches     2581     2752     +171     
==========================================
+ Hits         7638     8171     +533     
- Misses        239      483     +244     
- Partials      195      209      +14     

Flag	Coverage Δ
unittest	92.19% <83.33%> (-2.44%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/utils/src/ast-utils/helpers.ts	68.18% <75.00%> (ø)
packages/utils/src/ast-utils/predicates.ts	95.55% <100.00%> (ø)
packages/eslint-plugin/src/util/misc.ts	93.33% <0.00%> (-1.12%)	⬇️
...eslint-plugin/src/rules/no-useless-empty-export.ts
...plugin/src/rules/no-redundant-type-constituents.ts
...internal/src/rules/no-typescript-default-import.ts	100.00% <0.00%> (ø)
packages/type-utils/src/getTypeArguments.ts	25.00% <0.00%> (ø)
packages/type-utils/src/getSourceFileOfNode.ts	0.00% <0.00%> (ø)
packages/utils/src/eslint-utils/RuleTester.ts	9.30% <0.00%> (ø)
... and 52 more

[JoshuaKGoldberg]

❤️‍🔥

[JoshuaKGoldberg]

Ah, actually, codecov is right - could you make sure these are unit tested please?

At least isNotOptionalChainPunctuator is duplicated in user code.

[MichaelDeBoey]

@JoshuaKGoldberg The other helper functions also don't have any tests, so I think this is good to go as is?

[JoshuaKGoldberg]

Hmm, I suppose so. It would be nice to have them be unit tested directly but I guess if none of them are we can have that as a followup issue. 🤷

[JoshuaKGoldberg]

✅

[JoshuaKGoldberg]

This one I definitely cannot merge without an adult's help: