Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): remove "Related To" references to TSLint #5188

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Straight removal of most references to TSLint from the eslint-plugin package. TSLint has been deprecated for years now.

@nx-cloud
Copy link

nx-cloud bot commented Jun 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fc39689. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fc39689
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62b035fc074f9d0009bd8237
😎 Deploy Preview https://deploy-preview-5188--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #5188 (fc39689) into main (a30123d) will increase coverage by 2.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5188      +/-   ##
==========================================
+ Coverage   91.33%   93.82%   +2.49%     
==========================================
  Files         132      287     +155     
  Lines        1488     9862    +8374     
  Branches      224     2950    +2726     
==========================================
+ Hits         1359     9253    +7894     
- Misses         65      329     +264     
- Partials       64      280     +216     
Flag Coverage Δ
unittest 93.82% <ø> (+2.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/quotes.ts 88.88% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 94.64% <0.00%> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <0.00%> (ø)
...es/eslint-plugin/src/util/getOperatorPrecedence.ts 42.85% <0.00%> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 87.09% <0.00%> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts 100.00% <0.00%> (ø)
...lugin/src/rules/prefer-readonly-parameter-types.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-includes.ts 97.72% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/index.ts 100.00% <0.00%> (ø)
...plugin/src/rules/no-unnecessary-type-constraint.ts 88.00% <0.00%> (ø)
... and 145 more

@armano2 armano2 added documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Jun 15, 2022
@bradzacher bradzacher merged commit 34141b1 into typescript-eslint:main Jun 20, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-rule-tslint-related-to branch June 20, 2022 22:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Consider removing rule "Related To" references to TSLint
3 participants