feat(typescript-estree): added allowInvalidAST option to not throw on invalid tokens #6247
Thanks for the PR, @JoshuaKGoldberg!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings.
Additional details and impacted files
@@ Coverage Diff @@ ## v6 #6247 +/- ## ========================================== - Coverage 87.81% 87.72% -0.09% ========================================== Files 365 365 Lines 12455 12479 +24 Branches 3669 3679 +10 ========================================== + Hits 10937 10947 +10 - Misses 1158 1170 +12 - Partials 360 362 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
I'm not so sure this is the right approach to fixing the issue. It'd be hard to add branching logic for every possible syntactic issue not reported as such by TypeScript.
Instead, I'll look at using our isolated program to catch them.
Let this PR serve as a reference for what this logic could look like. 🙂
Edit: the isolated program is too slow. We're going with this! 🚀