Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error on invalid ThrowStatement #6561

Closed
wants to merge 1 commit into from

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Mar 3, 2023

PR Checklist

Overview

Throw same error for throw and throw\n

Ref: #1852 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bbf3815. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
Node 14 - nx test typescript-estree --coverage=false
✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bbf3815
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64015bf8d7c4e800081ce9ab
😎 Deploy Preview https://deploy-preview-6561--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2
Copy link
Member

armano2 commented Mar 5, 2023

resolved in #6247

@armano2 armano2 closed this Mar 5, 2023
@fisker fisker deleted the invalid-throw branch March 6, 2023 00:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants