New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable eslint checks for ci builds #67

Merged
merged 8 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@armano2
Copy link
Member

armano2 commented Jan 18, 2019

This PR adds basic setup for eslint linting of monorepo.

i had to disable some of recommended rules, and we should fix issues reported by them.

Show resolved Hide resolved .eslintrc.json Outdated

armano2 pushed a commit to armano2/typescript-eslint that referenced this pull request Jan 19, 2019

@armano2 armano2 dismissed stale reviews from j-f1 and JamesHenry via 3e9820f Jan 20, 2019

@armano2 armano2 force-pushed the armano2:eslint branch from 078f8ac to 3e9820f Jan 20, 2019

@armano2 armano2 force-pushed the armano2:eslint branch from f42b6e8 to 6975ef8 Jan 21, 2019

armano2 added some commits Jan 21, 2019

@JamesHenry
Copy link
Member

JamesHenry left a comment

Badges and CI task name as discussed

armano2 added some commits Jan 21, 2019

@JamesHenry JamesHenry merged commit 378fbe5 into typescript-eslint:master Jan 21, 2019

3 checks passed

Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 09f67ff...1845c01
Details
codecov/project 94.81% remains the same compared to 09f67ff
Details

@armano2 armano2 deleted the armano2:eslint branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment