Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing ! (...) around comparison cases in no-unnecessary-boolean-literal-compare fixer #6968

Conversation

tarunrajput
Copy link
Contributor

PR Checklist

Overview

add missing ! (...) around comparison cases in no-unnecessary-boolean-literal-compare fixer

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tarunrajput!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2a34765
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/645517180c344200088ffdb6
😎 Deploy Preview https://deploy-preview-6968--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tarunrajput tarunrajput force-pushed the fix/docs-no-unnecessary-boolean-literal-compare branch from 16498b7 to 2a34765 Compare May 5, 2023 14:47
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this PR - looks great! Thanks for sending @tarunrajput!

Tony the Tiger saying 'greeeaat'

@JoshuaKGoldberg JoshuaKGoldberg merged commit d4bc770 into typescript-eslint:main May 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: wrong information for rule in no-unnecessary-boolean-literal-compare
2 participants