Refactor/code action "Move to a new file" has stopped working

[ajitid]

I've seen this broken behavior in two editors — Neovim and Zed. It certainly used to work before.

This code action appears if you select a function and invoke a range code action. It used to create a new file and move the function along with the imports/references to this new file.

Current behavior: It creates a blank new file and doesn't might not make any code changes to the current file.

[rchl]

Are you able to provide some LSP communication logs from the editor?

[ajitid]

Sure! https://gist.github.com/ajitid/381c5082f3ec7064bb14ea51175c6f2c. The log mentions indexAt, this is a function that I was trying to move to a new file.

[rchl]

Thanks. Seems like server returns changes with wrong range (-1):

method = "workspace/applyEdit", params = {
        edit = {
            changes = {
                ...
                ["file:///home/ajitid/ghq/github.com/ajitid/fzf-for-js/src/lib/indexAt.ts"] = {
                    {
                        newText = "export function indexAt(index: number, max: number, forward: boolean) {\n    if (forward) {\n        return index;\n    }\n\n    return max - index - 1;\n}\n", range = {
                            end = {
                                character = -1,
                                line = -1
                            },
                            start = {
                                character = -1,
                                line = -1
                            }
                        }
                    }
                }
            }
        }
    }

To which the editor responds with an error:

{
    result = {
        applied = false,
        failureReason = "...nvim.aQx9chy/usr/share/nvim/runtime/lua/vim/lsp/util.lua:456: start_col out of bounds"
    }, status = true
}

Should be fixable.

[rchl]

It's potentially something that has changed/broke in some version of Typescript and could be reported in its repo but it should still be handled here, of course.

[ajitid]

Sublime LSP also uses this package, right? How come it is able to handle this code action just fine?

[rchl]

Likely because it's clamping the values which makes the start and end range correctly point at 0, 0

Spec defines Position as unsigned integer so -1 isn't really allowed.