Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplication of newlines #15

Merged
merged 1 commit into from
Nov 25, 2014
Merged

remove duplication of newlines #15

merged 1 commit into from
Nov 25, 2014

Conversation

yutopp
Copy link
Contributor

@yutopp yutopp commented Sep 13, 2014

each_line passes strings that hold a newline character. So, I think a newline character in per lines is inserted twice in current implementation.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) when pulling e770d57 on yutopp:remove_duplication_of_newlines into a07bef9 on typescript-ruby:master.

@rhysd
Copy link

rhysd commented Sep 14, 2014

LGTM 👍

@lorddoig lorddoig mentioned this pull request Sep 28, 2014
Closed
gfx added a commit that referenced this pull request Nov 25, 2014
@gfx
Merge pull request #15 from yutopp/remove_duplication_of_newlines
ce25205 
remove duplication of newlines
@gfx gfx merged commit ce25205 into typescript-ruby:master Nov 25, 2014
@gfx gfx mentioned this pull request Nov 25, 2014
Closed
@yutopp yutopp deleted the remove_duplication_of_newlines branch November 26, 2014 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yutopp @coveralls @rhysd @gfx