Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16

Closed
wants to merge 3 commits into from
Closed

Fixes #16

wants to merge 3 commits into from

Conversation

lorddoig
Copy link

  • Fixes a bug in replace_relative_references that was adding \n\n for every \n in the original source, which in turn was causing line numbers displayed in errors to be meaningless.
  • Make errors show the path to the asset file as opposed to the compilers tempfile. This is a kludge, but it works.
  • No new tests, but no failing tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.82%) when pulling 48efd8c on lorddoig:fixes into a07bef9 on typescript-ruby:master.

@lorddoig
Copy link
Author

The newline solution in #15 is more efficient, just noticed that.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.94%) when pulling 6576ca1 on lorddoig:fixes into a07bef9 on typescript-ruby:master.

@gfx
Copy link
Member

gfx commented Nov 25, 2014

I'm sorry to be late. I have merged #15. Is this pull-request still effective?

@gfx gfx closed this Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants