Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expire root TS cache in response to change in referenced .ts files #24

Merged
merged 3 commits into from
Mar 25, 2015
Merged

expire root TS cache in response to change in referenced .ts files #24

merged 3 commits into from
Mar 25, 2015

Conversation

wtmcc
Copy link
Contributor

@wtmcc wtmcc commented Feb 10, 2015

This PR is intended to fix the undesirable behavior described in issue #23 by the approach I propose there. See that issue for context.

Here, I introduce a step into the TS compiler wrapper that recurses through all referenced files and tells its Sprockets::Context that the TS file being processed depends_on each file listed as a reference in the TS idiom.

I may have overlooked an easy fix, and Ruby’s not my native language, so feel free to suggest stylistic or other changes! I’m eager to help, and solve our local dev env woes for good. Thanks.

Will

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.58%) to 97.33% when pulling fda85ef on wtmcc:depend-on-references into cef909f on typescript-ruby:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) to 98.18% when pulling 7c4e15b on wtmcc:depend-on-references into cef909f on typescript-ruby:master.

@wtmcc wtmcc changed the title expire root TS cache in response to change in referenced .ts files for issue #23 expire root TS cache in response to change in referenced .ts files Feb 10, 2015
@klaustopher
Copy link
Contributor

Pinging @gfx

@gfx
Copy link
Member

gfx commented Mar 25, 2015

Sorry to be late! LGTM.

gfx added a commit that referenced this pull request Mar 25, 2015
expire root TS cache in response to change in referenced `.ts` files
@gfx gfx merged commit e56a1dc into typescript-ruby:master Mar 25, 2015
@vexus2
Copy link

vexus2 commented Mar 25, 2015

👍

@funnythingz
Copy link

LGTM!!ありがとうございます!
Thanks!!!

@wtmcc
Copy link
Contributor Author

wtmcc commented Mar 25, 2015

Awesome, thanks for the merge, @gfx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants