Remove duplicated types #262
Conversation
|
@NoNameProvided Can you check this out so we could merge this? :) |
|
@19majkel94 How things usually go in this repo with PRs? How we get this merged? |
|
@NoNameProvided is in charge here, I have no npm publish access 😕 |
|
@NoNameProvided This should be easy to review. Care to take a look? :) |
| @@ -23,6 +23,7 @@ | |||
| "typescript-validator" | |||
| ], | |||
| "dependencies": { | |||
| "@types/validator": "9.4.2", | |||
There was a problem hiding this comment.
This should be in dev dependencies, but I will move it.
|
Thanks for the contribution @henrikra! |
|
@NoNameProvided Thank you! Btw have guys though about adding some other guy with publish rights? Because usually people are not patient enough to wait over 2 months for their PR to be merged. I would suggest @19majkel94 :) |
|
I think our team need more contributors and volunteers for this project as we have limited time for all of the open source projects 😞 Then others could review PRs and maintain the repo with only publishing responsibility on our side. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR removes duplicated types in
ValidationTypeOptions.tsbecause they can be imported from@types/validator. This way the types always match and we don't have to sync them manually.Also I update
@types/validatorto9.4.2because I added options forisNumeric. PR is here DefinitelyTyped/DefinitelyTyped#28600No breaking changes. Tell me what you guys think :)
Fixes #253