Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply custom constraint class validation to each item in the array #295

Merged
merged 4 commits into from Oct 1, 2019
Merged

Conversation

zd333
Copy link
Contributor

@zd333 zd333 commented Dec 10, 2018

When @Validate + some custom constraint class is used with { each: true }, then it is expected to be applied to each item of the target object field:
#260

@zd333
Copy link
Contributor Author

zd333 commented Jan 2, 2019

@pleerock Hi! Please review.

@MichalLytek MichalLytek requested review from pleerock and NoNameProvided and removed request for pleerock January 2, 2019 14:27
@zd333
Copy link
Contributor Author

zd333 commented Feb 27, 2019

@pleerock @NoNameProvided please find a minute to review this.
If there is something I can improve/change before review (to make it easier) - please let me know.
Thank you.

@zd333
Copy link
Contributor Author

zd333 commented Jun 6, 2019

@pleerock @NoNameProvided
Hello.
Kindly reminding to review :)

@TrejGun
Copy link

TrejGun commented Sep 6, 2019

works like magic, please merge

@TrejGun
Copy link

TrejGun commented Sep 19, 2019

@vlapo ping!

@zd333
Copy link
Contributor Author

zd333 commented Sep 19, 2019

@pleerock @NoNameProvided @vlapo this PR is waiting for review for several months and currently has conflicts with recent code. I'm ready to resolve those, but not sure if it makes sense and somebody is going to review the PR.
If so - then please let me know and will resolve conflicts.
Thank you!

@Wissam-Sandbox
Copy link

Wissam-Sandbox commented Sep 24, 2019

@NoNameProvided Please take a look at @zd333's PR. It definitely solves this issue.
Thanks!

@vlapo
Copy link
Contributor

vlapo commented Sep 24, 2019

Hey @zd333, sorry for such delay. Could you please rebase and I will review PR. Thank you for your patient.

@zd333
Copy link
Contributor Author

zd333 commented Sep 27, 2019

@vlapo rebased.
I believe now PR is ready for review, please take a look when you have time.
Thank you.

@vlapo
Copy link
Contributor

vlapo commented Oct 1, 2019

Looks good. Tests are green, code looks really good. Again, thank you for your endurance.

@vlapo vlapo merged commit 5bb704e into typestack:master Oct 1, 2019
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants