Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add @IsBase58 validator #1765

Merged
merged 1 commit into from Dec 2, 2022
Merged

feat: add @IsBase58 validator #1765

merged 1 commit into from Dec 2, 2022

Conversation

Kinggodhoon
Copy link
Contributor

@Kinggodhoon Kinggodhoon commented Oct 19, 2022 •
edited by NoNameProvided

Description

Adds implementation for @IsBase58 validator. It checks whether the given string is a valid Base58 encoded string or not.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

references #1821

@braaar braaar mentioned this pull request Oct 20, 2022
Closed
@braaar
Copy link
Member

braaar commented Oct 20, 2022

Nice PR! I've added this to my epic #1747

@NoNameProvided
Copy link
Member

Please rebase for review.

@Kinggodhoon Kinggodhoon reopened this Nov 23, 2022
@Kinggodhoon
Copy link
Contributor Author

@NoNameProvided
I did rebase.

I'm not sure if this is right because I'm a beginner in development.

It would be very helpful if you could let me know if there is a better way.

thank you.

@NoNameProvided NoNameProvided changed the title feat: Implement @IsBase58 validator feat: implement @IsBase58 validator Dec 2, 2022
@NoNameProvided NoNameProvided changed the title feat: implement @IsBase58 validator feat: add @IsBase58 validator Dec 2, 2022
@NoNameProvided NoNameProvided merged commit 3976453 into typestack:develop Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NoNameProvided NoNameProvided NoNameProvided approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kinggodhoon @braaar @NoNameProvided