Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improved validation message for unknown property #1966

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Recodify
Copy link

Description

Gives you a clue as to what property in the source object caused an unknown value was passed to the validate function

Before: an unknown value was passed to the validate function
After: an unknown value was passed to the validate function for property user

@tsa96
Copy link

tsa96 commented Mar 9, 2023

This looks like a useful change, but do you realize you've included a 10k lines of package-lock.json changes? I don't know what the review process on this repo looks like but I'd recommend just reset --mixeding your branch and recommitting without all that, then force-pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants