Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for phone number validation strategy #940

Closed
wants to merge 3 commits into from
Closed

feat: add support for phone number validation strategy #940

wants to merge 3 commits into from

Conversation

fwoelffel
Copy link

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #939

fwoelffel and others added 2 commits December 6, 2022 10:37
Co-authored-by: Brage Sekse Aarset <brage.aarset@gmail.com>
@NoNameProvided
Copy link
Member

Thanks for opening this PR, but this won't get merged.

I don't think the pros outweigh the cons:

  • I believe the vast majority of validation use cases check for valid phone numbers only
  • it introduces a custom option that doesn't exist in the source lib and I prefer having all validators run with as little custom config as possible
  • we actually changed to check for letters in phone numbers and fail the check and this is not possible with this approach

If you need this you can always create a custom decorator and use that.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

feature: allow relying on libphonenumber's isPossible for phone numbers validation
3 participants