Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ugly @MiddlewareGlobalAfter and @MiddlewareGlobalBefore #108

Closed
pleerock opened this issue Apr 5, 2017 · 4 comments
Closed

Ugly @MiddlewareGlobalAfter and @MiddlewareGlobalBefore #108

pleerock opened this issue Apr 5, 2017 · 4 comments

Comments

@pleerock
Copy link
Contributor

pleerock commented Apr 5, 2017

I really don't like @MiddlewareGlobalAfter and @MiddlewareGlobalBefore names. I never did. What if we find a better name for those decorators or deprecate them and use simply:

@Middleware({ global: true, type: "after"|"before" })

instead? @19majkel94
@MichalLytek
Copy link
Contributor

+1 👍

Also we have to split middleware interface for koa and express.

@pleerock
Copy link
Contributor Author

pleerock commented Apr 5, 2017

yes agree

@pleerock pleerock mentioned this issue Apr 24, 2017
Merged
@pleerock
Copy link
Contributor Author

fixed in 0.7.0

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pleerock @MichalLytek