Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: class-validator version 0.10.1 explicitly required #550

Closed
sergey-prokofiev opened this issue Mar 20, 2020 · 6 comments
Closed
Assignees
Labels
type: question Questions about the usage of the library.
Milestone

Comments

@sergey-prokofiev
Copy link

routing-controllers refers to a concrete version(0.10.1) of class-validator

"class-validator": "0.10.1"

instead of typical 'auto-update patches and minor versions' approach, like ^0.10.1.
For example, class-transformer is used with mentioned auto-update approach:
"class-transformer": "^0.2.3",

So I can't update to the latest version of class-validator (0.11.1).
Why it was done in this way?

@Roeis
Copy link

Roeis commented Apr 8, 2020

same question here. is this something like misspelling issue?

@theprobugmaker
Copy link

bump @pleerock @MichalLytek

@MichalLytek
Copy link
Contributor

@zefexdeveloper ping @jotamorais, not us, as he's the maintainer now 😉

@jotamorais
Copy link
Member

This was introduced in #472 and it has been object of several discussions previous to that (whether to keep as a project dependency or move it to peerDependencies exclusively.
For now, I will fix the auto-update, but need feedback whether it makes sense for class-transformer & class-validator to move to peerDependencies only.

Related: #369, #384 and #452

@jotamorais jotamorais self-assigned this Jun 5, 2020
@jotamorais jotamorais added enhancement type: question Questions about the usage of the library. labels Jun 5, 2020
@jotamorais jotamorais added this to the 0.9.x release milestone Jun 5, 2020
@theprobugmaker
Copy link

@jotamorais I think it should continue as a peerDependencies. Thank you very much.

@NoNameProvided NoNameProvided changed the title Reference to 0.10.1 version of class-validator question: reference to 0.10.1 version of class-validator Aug 9, 2020
@NoNameProvided NoNameProvided changed the title question: reference to 0.10.1 version of class-validator question: class-validator version 0.10.1 explicitly required Aug 9, 2020
@typestack typestack locked as resolved and limited conversation to collaborators Aug 9, 2020
@NoNameProvided
Copy link
Member

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: question Questions about the usage of the library.
Development

No branches or pull requests

6 participants