Fix: Remove trailing slash from route path in KoaDriver #1114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before the update,
@koa/router
allowed path declared with a trailing slash to be accessible both with or without trailing slashAfter the update, only trailing slash path is accessible. This makes registering nested routes with
@Get('/')
infeasible, when one does not use trailing slashes for URLs.Proposed change, restricted in scope to affected KoaDriver only, removes the trailing slash if one appears in the route (aside from
/
).@koa/router
allows such paths to be accessed both with and without trailing slash, as before.Please note
@Get('/')
is what official tests are using, and it works just fine with express:https://github.com/typestack/routing-controllers/blob/develop/test/functional/controller-base-routes.spec.ts#L18-L21
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
Fixes #1113