空objectのテストを追加。write_u24の処理が違っていたのを修正

typester · Aug 14, 2008 · a2bf203 · a2bf203
1 parent 15d7ca1
commit a2bf203
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/lib/Data/AMF/IO.pm b/lib/Data/AMF/IO.pm
@@ -133,8 +133,10 @@ sub write_s16 {
 sub write_u24 {
     my ($self, $data) = @_;
 
-    return $self->write( pack('CCC', $data) ) if ENDIAN eq 'BIG';
-    return $self->write( swap pack('CCC', $data) );
+    $data = pack('N', $data);
+    $data = substr $data, 1, 3;
+
+    $self->write($data);
 }
 
 sub write_u32 {

diff --git a/t/01_parse_amf0.t b/t/01_parse_amf0.t
@@ -7,7 +7,6 @@ use File::Spec;
 
 use Data::AMF;
 
-
 my $amf = Data::AMF->new( version => 0 );
 
 sub load {
@@ -70,6 +69,11 @@ data:
   hash:
     foo: bar
 
+=== null object
+--- input: data/amf0/null_object
+--- expected
+data: {}
+
 === null
 --- input: data/amf0/null
 --- expected

diff --git a/t/02_format_amf0.t → t/02_format_amf0_simple.t b/t/02_format_amf0.t → t/02_format_amf0_simple.t
@@ -47,6 +47,10 @@ data: foo
 data:
   foo: bar
 
+=== null object
+--- input
+data: {}
+
 === object2
 --- input
 data: