Update free-style to version 3.1.0 and other deps updates #350
Conversation
1. Upgraded to freestyle 3.1.0
a) The $displayName property was added in 3.0.0 and is effectively the
$debugName we were using. Because freestyle does not have the debug
parameter anymore, the code around $debugName has been simplified to
passthrough to the $displayName property.
b) The IS_UNIQUE property was changed to be $unique. This is the same
property name that is used in TypeStyle, so no special handling is
needed. All the special handling has been removed.
c) Due to these changes, we should treat this as a major version.
2. Upgraded webpack
a) Added mode.
b) Replaced uglify with optimization property. Uglify plugin is no
longer supported
3. Renamed internal formatting functions to convertToKeyframes and
convertToStyles. Also simplified the types used.
notoriousb1t
changed the title
|
@basarat, could you spot check this for me? I haven't made significant changes to this codebase in a while and I haven't had any opportunity to do React development since I joined Google. I actually meant to just hit some merge buttons to clear my inbox, but the free-style api changed and many of our deps were pretty out of date. It looks like this also closes our other PR for $debugName since free-style depends on node environment now and doesn't have a parameter for this. This fixes that request. Let me know what you think. If this looks good, I'll up the major version and see what changes need to be made to the docs site. |
Looks good 👍 |
|
@notoriousb1t from commit : 5e73b7e
I disagree. I don't see any breaking changes for our consumers : our If you are okay I'll cut a minor release to include this along with other changes (that are also minor) 👍 |
|
Perhaps I was being overly cautious here. SGTM 👍 |
|
Released 2.1.0 🌹 |
Closes #346