Handle uninferred type parameter in array accesses (Fixes #3020) #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smillst
requested changes
Feb 25, 2020
| @@ -224,8 +225,17 @@ public AnnotatedTypeMirror visitArrayAccess(ArrayAccessTree node, AnnotatedTypeF | |||
| f.visitorState.setAssignmentContext(null); | |||
|
|
|||
| AnnotatedTypeMirror type = f.getAnnotatedType(node.getExpression()); | |||
| assert type instanceof AnnotatedArrayType; | |||
| return ((AnnotatedArrayType) type).getComponentType(); | |||
| if (type instanceof AnnotatedArrayType) { | |||
There was a problem hiding this comment.
Should this is TypeKinds instead of instanceof?
| return ((AnnotatedArrayType) type).getComponentType(); | ||
| } else if (type instanceof AnnotatedWildcardType) { | ||
| // Clean-up after Issue #979. | ||
| AnnotatedWildcardType wc = (AnnotatedWildcardType) type; |
There was a problem hiding this comment.
Do you expect this to be an uninferred type argument? If so should we check that it is?
|
@smillst Thanks for the comments, I've addressed both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.