Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the checkNullness task #6236

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

mernst
Copy link
Member

@mernst mernst commented Oct 12, 2023

No description provided.

build.gradle Outdated
@@ -799,6 +799,9 @@ subprojects {
createCheckTypeTask(project.name, 'Signature',
'org.checkerframework.checker.signature.SignatureChecker')

// The checkNullness task runs on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right. checkNullness runs on all code. In the framework and checker subprojects, it only checks code marked @AnnotatedFor.

@smillst smillst assigned mernst and unassigned smillst Oct 13, 2023
@mernst
Copy link
Member Author

mernst commented Oct 13, 2023

@smillst Is this comment better?

@mernst mernst assigned smillst and unassigned mernst Oct 13, 2023
Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much clearer. Thanks!

@smillst smillst enabled auto-merge (squash) October 13, 2023 16:23
@smillst smillst merged commit 0b8da55 into typetools:master Oct 13, 2023
29 checks passed
@smillst smillst deleted the checkNullness-doc branch October 13, 2023 19:09
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants