-
Notifications
You must be signed in to change notification settings - Fork 432
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
f953a11
commit eb87e26
Showing
3 changed files
with
6 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb87e26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is causing problems for me updating VCR to utilize the new
encoded_body
API you added for me. VCR still supports 1.8.7 (I plan to drop support in VCR 3.0 but SemVer dictates that I can't drop support before then).thread_safe
0.1.3 doesn't support MRI 1.8.7 properly, sadly (I getuninitialized constant ThreadSafe::Array
errors). It looks like this got fixed in headius/thread_safe#7 but there hasn't been a gem release with that fix yet.@headius -- any chance you could release a new
thread_safe
gem so we have a version that works on 1.8.7? Or, if that's not going to happen soon, @i0rek, could you cut a gem release w/o this but with theencoded_body
API?eb87e26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myronmarston I've reverted this commit.
eb87e26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!