Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for iOS 9 and Safari 9 compatibility #101

Merged
merged 1 commit into from
Oct 22, 2015

Conversation

ltullman
Copy link
Collaborator

Add workaround for isArray check failing due to Arguments not being recognized as an Array in Safari 9.

Add workaround for isArray check failing due to Arguments not being recognized as an Array in Safari 9.
@mmikowski
Copy link
Collaborator

Hi Ltullman:

Thanks for your work!

I have incorporated this change, as well as regression tests (!) and jslint fixes in this branch: https://github.com/mmikowski/taffydb. Please check it out :)

I added rudimentary regression tests, but they are easy to expand and port to run headless on node.js (see taffy-test.html)

We should look at forking this project if Ian cannot be found. I'm willing to guide the project and even asked him if I could take over, but haven't heard back from him.

It would be sad to fork, but even worse if we couldn't keep using this software. A few thoughts if we went that way:

  • We would need a new name that is sticky and evokes memories of taffydb
  • We should see if we could get Ian to point others to the new project, or (again, better yet) just transfer TaffyDB to new management
  • We definitely want to compare to existing projects to see if something better or redundant has come along

Cheers, Mike

@ltullman
Copy link
Collaborator Author

Hi Mike, You're welcome and I agree about this project needing a maintainer again. I sent Ian a tweet so hoping he replies.

@mmikowski
Copy link
Collaborator

Same here. Thanks for your help. It fixed our iOS9 bug for our VP and CEO. Very helpful!

@LucasLazaro
Copy link

Apparently I'm facing a similar problem, when inserting entries to a DB it does not persist. Trying to retrieve gives me an empty array or simply db().count() = 0.

@ltullman Was your fix intended to fix this issue?

@ltullman
Copy link
Collaborator Author

@LucasLazaro Yeah, it should solve that.

@typicaljoe
Copy link
Owner

Are you guys willing to merge these changes into the base branch?

@mmikowski
Copy link
Collaborator

This looks good to me. I tested here. iOS9 now works, and regression tests pass.

@mmikowski mmikowski merged commit 0e44c6a into typicaljoe:master Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants