Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: git-worktree #407

Merged
merged 1 commit into from
Apr 27, 2019
Merged

Fix: git-worktree #407

merged 1 commit into from
Apr 27, 2019

Conversation

JasCodes
Copy link
Contributor

@typicode Hey feel free to reformat and pull it in.

Thx

@JasCodes JasCodes mentioned this pull request Nov 24, 2018
@typicode
Copy link
Owner

Thanks for the PR :)
What would be the git commands/steps to setup a test repo to try this feature?

@JasCodes
Copy link
Contributor Author

Lets say we have master and feature1 branch and master branch is checked out.
Now with something like git worktree add ../feature1 feature1; you can check feature1 branch to location ../feature1.
https://spin.atomicobject.com/2016/06/26/parallelize-development-git-worktrees/

Now for some reason hooks in worktree only works if they are in .git/hooks and not in .git/worktree/feature1/hooks

@bbugh
Copy link

bbugh commented Apr 24, 2019

Is there any way to assist in getting this merged? We spent some time setting up husky only to realize that it doesn't support worktrees, which we use extensively. This "should be" a relatively small fix as the .git file in a worktree just points to the expected path. The PR looks correct in how I'd expect it to work.

@JasCodes
Copy link
Contributor Author

@bbugh No idea why its not accepted myself. @typicode Can review agaist master branch if still interested.

@typicode typicode merged commit f1b1441 into typicode:master Apr 27, 2019
@typicode
Copy link
Owner

Thanks for the offered help and sorry for the time to merge/review.
It'll be part of the next release.

@bbugh
Copy link

bbugh commented May 2, 2019

Awesome! This is working very well. Thank you @JasCodes and @typicode for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants